Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement $struct$unnest() #1010

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Implement $struct$unnest() #1010

wants to merge 6 commits into from

Conversation

etiennebacher
Copy link
Collaborator

Part of #998

pl$Series(name = "foo", values = 1)$to_struct()$struct$unnest()
shape: (1, 1)
┌─────┐
│ foo │
│ --- │
│ f64 │
╞═════╡
│ 1.0 │
└─────┘

@eitsupi I did as in #1002 but I'm not sure it's what you had in mind

@etiennebacher etiennebacher requested a review from eitsupi April 2, 2024 11:36
@eitsupi
Copy link
Collaborator

eitsupi commented Apr 2, 2024

I think this is a good implementation, but the Rd file is not generated.
I think we can merge them for the time being and think about the documentation later.

I was imagining that it would be better to define the SeriesStruct_unnest and make it something like unnest=SeriesStruct_unnest

@etiennebacher
Copy link
Collaborator Author

the Rd file is not generated

It is generated, I just had to specify the @name otherwise it's named Series_unnest

@etiennebacher
Copy link
Collaborator Author

Ah no my bad, the usage section is wrong

@etiennebacher etiennebacher marked this pull request as draft April 2, 2024 16:29
@etiennebacher
Copy link
Collaborator Author

I'd rather find a solution here than coming back later for this.

@eitsupi
Copy link
Collaborator

eitsupi commented May 22, 2024

Can we merge this?

@etiennebacher
Copy link
Collaborator Author

No the Usage section in the docs is still wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebacher @eitsupi